Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell: Add cabal2nixOptions to developPackage #103660

Merged
merged 1 commit into from Nov 13, 2020

Conversation

@expipiplus1
Copy link
Contributor

@expipiplus1 expipiplus1 commented Nov 13, 2020

Motivation for this change

Currently it's quite cumbersome to set these options with developPackages (have to override callCabal2xnix)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Also neaten documentation slightly
@expipiplus1 expipiplus1 requested a review from cdepillabout as a code owner Nov 13, 2020
expipiplus1 added a commit to expipiplus1/vulkan that referenced this pull request Nov 13, 2020
Copy link
Member

@cdepillabout cdepillabout left a comment

Looks good! All these changes are really making developPackage easier to use.

@cdepillabout cdepillabout merged commit d3edc3a into NixOS:haskell-updates Nov 13, 2020
2 of 4 checks passed
2 of 4 checks passed
tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
@expipiplus1
Copy link
Contributor Author

@expipiplus1 expipiplus1 commented Nov 13, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.