Skip to content

/ nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.gsconnect: 43 -> 44 #103666

Merged
merged 1 commit into from Nov 14, 2020
Merged

gnomeExtensions.gsconnect: 43 -> 44 #103666

merged 1 commit into from Nov 14, 2020

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 13, 2020 •
edited

Motivation for this change

Gnome 3.38 - #95248 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar
gnomeExtensions.gsconnect: 43 -> 44
Loading status checks…
d2a55a7
@doronbehar doronbehar requested a review from jtojnar Nov 13, 2020
@ofborg ofborg bot added the 6.topic: GNOME label Nov 13, 2020
@ofborg ofborg bot requested a review from etu Nov 13, 2020
@jtojnar
jtojnar approved these changes Nov 13, 2020
View changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Changes look okay https://github.com/andyholmes/gnome-shell-extension-gsconnect/releases/tag/v44
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 13, 2020 •
edited

Looks like installed tests still fail on LAN test but that is not a regression.
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Nov 13, 2020

Will merge once I see this working after I will use my system with this merged to my nixpkgs fork.
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Nov 14, 2020

Works.
@doronbehar doronbehar merged commit d67b00e into NixOS:master Nov 14, 2020
19 of 20 checks passed
19 of 20 checks passed
tests
Details
action
Details
gnomeExtensions.gsconnect, gnomeExtensions.gsconnect.passthru.tests on x86_64-darwin
Details
gnomeExtensions.gsconnect, gnomeExtensions.gsconnect.passthru.tests on aarch64-linux Timed out, unknown build status
Details
gnomeExtensions.gsconnect, gnomeExtensions.gsconnect.passthru.tests on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2a55a7"; rev="d2a55a7fc53e60c6268b73ada88804083f9dbaaf"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2a55a7"; rev="d2a55a7fc53e60c6268b73ada88804083f9dbaaf"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2a55a7"; rev="d2a55a7fc53e60c6268b73ada88804083f9dbaaf"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2a55a7"; rev="d2a55a7fc53e60c6268b73ada88804083f9dbaaf"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2a55a7"; rev="d2a55a7fc53e60c6268b73ada88804083f9dbaaf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2a55a7"; rev="d2a55a7fc53e60c6268b73ada88804083f9dbaaf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2a55a7"; rev="d2a55a7fc53e60c6268b73ada88804083f9dbaaf"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@doronbehar doronbehar deleted the doronbehar:pkg/gnomeExtensions/gsconnect branch Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@etu etu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1 10.rebuild-linux: 1-10 6.topic: GNOME 8.has: upstream changes reviewed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@doronbehar @jtojnar
You can’t perform that action at this time.