Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor-browser-bundle-mutable: init #103668

Draft
wants to merge 1 commit into
base: master
from
Draft

Conversation

@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Nov 13, 2020

Motivation for this change

Spin off from #103156

This offers an alternative FHS based packaging for the tor browser. This may be useful for some people (due to faster updates, or perhaps less chance of breakage, due to being closer to upstream), but obviously has its drawbacks. It is not as close to the spirit of Nix / NixOS and will waste disk space, by keeping a separate copy of the (compressed) source in the store, in addition to the one in the local prefix.
Another rationale for writing this may be that mozilla is known for increasingly trying to lock down the browser, thereby sadly making the kind of packaging as required in nixpkgs more difficult to do properly.

Implementation details
  • It uses .local/share/tor-browser-mutable/ as prefix (separate from the prefix of tor-browser-bundle-bin), so they should not collide.
  • It adds some things to the passthru attribute of tor-browser-bundle-bin, to keep versions in sync; hope that's a valid thing to do.
Things done
  • running works and NoScript / addons as well
  • checked that the tor browsers self update mechanism works
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
if ! [[ -f "$TBB_HOME/start-tor-browser" ]]
then
Comment on lines 46 to 47

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 24, 2020
Member

Suggested change
if ! [[ -f "$TBB_HOME/start-tor-browser" ]]
then
if [[ ! -f "$TBB_HOME/start-tor-browser" ]]; then
]
++ lib.optionals pulseaudioSupport [
Comment on lines 93 to 94

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 24, 2020
Member

Suggested change
]
++ lib.optionals pulseaudioSupport [
] ++ lib.optionals pulseaudioSupport [
@xaverdh xaverdh force-pushed the xaverdh:tor-browser-mutable branch from cbc523e to b44c51a Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants