Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-3.pomodoro: 0.17.0 -> 0.18.0 #103675

Merged
merged 1 commit into from Nov 18, 2020
Merged

Conversation

@jsravn
Copy link
Contributor

@jsravn jsravn commented Nov 13, 2020

Motivation for this change

Needed for the extension to work with the current Gnome 3 version in master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Needed to work with the current Gnome 3 version in master.
Copy link
Contributor

@jtojnar jtojnar left a comment

Changes look okay. libindicator support has been removed but we did not have it in the first place.

codito/gnome-pomodoro-local@0.17.0...0.18.0

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 18, 2020

@GrahamcOfBorg build gnome3.pomodoro

@jtojnar jtojnar merged commit e4883cb into NixOS:master Nov 18, 2020
2 of 5 checks passed
2 of 5 checks passed
action action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
gnome3.pomodoro on aarch64-linux
Details
gnome3.pomodoro on x86_64-darwin
Details
gnome3.pomodoro on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.