Skip to content

/ nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wofi: 1.2.1 -> 1.2.3 #103701

Merged
merged 1 commit into from Nov 13, 2020
Merged

wofi: 1.2.1 -> 1.2.3 #103701

merged 1 commit into from Nov 13, 2020

Conversation

@Technical27
Copy link
Contributor

@Technical27 Technical27 commented Nov 13, 2020

Motivation for this change

wofi just randomly broke after an update and updating to 1.2.3 fixed the issue.

Things done

Update wofi.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Technical27
wofi: 1.2.1 -> 1.2.3
Verified
This commit was signed with a verified signature.
Technical27
GPG key ID: F930CFBFF5D7FDC3 Learn about signing commits
Loading status checks…
8775e39 
This also fixes a GDK Protocol error.
@ofborg ofborg bot requested a review from Elyhaka Nov 13, 2020
@dywedir
Copy link
Member

@dywedir dywedir commented Nov 13, 2020

Thanks for the PR!
@dywedir dywedir merged commit b6112b3 into NixOS:master Nov 13, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8775e39"; rev="8775e3975718c8e4e47195579ac2f606a020072a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8775e39"; rev="8775e3975718c8e4e47195579ac2f606a020072a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8775e39"; rev="8775e3975718c8e4e47195579ac2f606a020072a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8775e39"; rev="8775e3975718c8e4e47195579ac2f606a020072a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8775e39"; rev="8775e3975718c8e4e47195579ac2f606a020072a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8775e39"; rev="8775e3975718c8e4e47195579ac2f606a020072a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8775e39"; rev="8775e3975718c8e4e47195579ac2f606a020072a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
wofi, wofi.passthru.tests on aarch64-linux Success
Details
wofi, wofi.passthru.tests on x86_64-linux Success
Details
@Technical27 Technical27 mentioned this pull request Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elyhaka Elyhaka

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Technical27 @dywedir