Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.dash-to-panel: 39 -> 40 #103702

Merged
merged 1 commit into from Nov 15, 2020
Merged

gnomeExtensions.dash-to-panel: 39 -> 40 #103702

merged 1 commit into from Nov 15, 2020

Conversation

@buckley310
Copy link
Contributor

@buckley310 buckley310 commented Nov 13, 2020

Motivation for this change

Support GNOME 3.38

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@felschr felschr left a comment

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • all depending packages build
Comments

Works with GNOME setup.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 15, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/284

@Lassulus Lassulus merged commit f2437fc into NixOS:master Nov 15, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
gnomeExtensions.dash-to-panel, gnomeExtensions.dash-to-panel.passthru.tests on aarch64-linux Success
Details
gnomeExtensions.dash-to-panel, gnomeExtensions.dash-to-panel.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67394b5"; rev="67394b5efdc8d5e554a668681fab029b1eb3ad70"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67394b5"; rev="67394b5efdc8d5e554a668681fab029b1eb3ad70"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67394b5"; rev="67394b5efdc8d5e554a668681fab029b1eb3ad70"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67394b5"; rev="67394b5efdc8d5e554a668681fab029b1eb3ad70"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67394b5"; rev="67394b5efdc8d5e554a668681fab029b1eb3ad70"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67394b5"; rev="67394b5efdc8d5e554a668681fab029b1eb3ad70"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67394b5"; rev="67394b5efdc8d5e554a668681fab029b1eb3ad70"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@buckley310 buckley310 mentioned this pull request Dec 21, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants