Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vte-ng: update patches to apply on vte 0.62 #103704

Merged
merged 1 commit into from Nov 14, 2020
Merged

Conversation

@JJJollyjim
Copy link
Contributor

@JJJollyjim JJJollyjim commented Nov 13, 2020

Motivation for this change

Closes #103643

The upstream vte-ng patches from 0.56 have applied cleanly up until now, 0.62 added noexcept modifiers everywhere so a modification was necessary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@JJJollyjim
Copy link
Contributor Author

@JJJollyjim JJJollyjim commented Nov 13, 2020

@ofborg build termite

@asbachb
Copy link
Contributor

@asbachb asbachb commented Nov 14, 2020

Works for me.

@teto teto merged commit 2ac6d50 into NixOS:master Nov 14, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0910383"; rev="09103830f727591fe673c8b01a5e19c9e4f2fd01"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0910383"; rev="09103830f727591fe673c8b01a5e19c9e4f2fd01"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0910383"; rev="09103830f727591fe673c8b01a5e19c9e4f2fd01"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0910383"; rev="09103830f727591fe673c8b01a5e19c9e4f2fd01"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0910383"; rev="09103830f727591fe673c8b01a5e19c9e4f2fd01"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0910383"; rev="09103830f727591fe673c8b01a5e19c9e4f2fd01"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0910383"; rev="09103830f727591fe673c8b01a5e19c9e4f2fd01"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
termite on aarch64-linux Success
Details
termite on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.