Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plik: init at 1.3.1 #103705

Open
wants to merge 3 commits into
base: master
from
Open

plik: init at 1.3.1 #103705

wants to merge 3 commits into from

Conversation

@freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 13, 2020

Motivation for this change

Add package, module and test for plik

Currently, the web frontend is extracted from the release from upstream due to problems to
build it. I hope to fix this in a future update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@aanderse aanderse left a comment

Thanks for the module. I'll probably make use of it at some point 👍

I have left a few comments I hope you find helpful. If you have any questions or want any clarification just let me know. Happy to help in any way I can.

nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/plikd.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/plikd.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/plikd.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/plikd.nix Show resolved Hide resolved
nixos/modules/services/misc/plikd.nix Outdated Show resolved Hide resolved
};

config = mkIf cfg.enable {
systemd.services.plikd = {

This comment has been minimized.

@aanderse

aanderse Nov 14, 2020
Contributor

After we merge this PR you might consider contributing this systemd unit to upstream. I'm sure they would benefit from your contribution.

nixos/modules/services/misc/plikd.nix Outdated Show resolved Hide resolved
nixos/tests/plikd.nix Show resolved Hide resolved
@freezeboy freezeboy force-pushed the freezeboy:add-plik branch from b7cce9f to 9e2192a Nov 14, 2020
@freezeboy
Copy link
Contributor Author

@freezeboy freezeboy commented Nov 14, 2020

Thank you for your comments, I tried to fix them, I am still not very sure how to address the "settings" key to have a flexible solution, but not too much hurdle for the admin also

@freezeboy freezeboy force-pushed the freezeboy:add-plik branch from 9e2192a to f046631 Nov 29, 2020
@freezeboy freezeboy changed the title Add plik plik: init at 1.3.1 Nov 29, 2020
@freezeboy freezeboy force-pushed the freezeboy:add-plik branch from f046631 to 8a321fc Nov 29, 2020
@freezeboy
Copy link
Contributor Author

@freezeboy freezeboy commented Nov 29, 2020

@aanderse, following the example on n8n module, I fixed this one too, and added the hardening config too

Copy link
Contributor

@aanderse aanderse left a comment

Module LGTM 👍 Unfortunately I don't generally review packages (and know almost nothing about go), so we should get someone else to review this.

@freezeboy freezeboy force-pushed the freezeboy:add-plik branch 2 times, most recently from fdf50ab to 5714411 Nov 29, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Dec 8, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/401

freezeboy added 3 commits Nov 12, 2020
The client and the servers are separated so that a simple user just gets
the necessary binary.

Currently the server frontend has a very old build, I could not build
this asset myself, so for the moment I simply extracted it from the
binary release of the project.

Once this build procedure will have been updated I will transition to a
full build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.