Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.phonemizer: init at 2.2.1 #103714

Merged
merged 1 commit into from Nov 14, 2020
Merged

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 13, 2020

Motivation for this change

Part of @Mic92 and my plan to package Mozilla TTS.

This step includes phonemizer, a library to convert text to phonemes.

It supports multiple backends, like espeak and festival. Unfortunately we couldn't get the festival backend to work, so we didn't include it.

E           RuntimeError: Command "/nix/store/3jb8rhr9ls6lwmrsahnwcq4v53kv3aw3-festival-2.5.0/bin/festival -b /build/tmpyi73uuuh" returned exit status 255, output is:
E           -=-=-=-=-=- EST Error -=-=-=-=-=-
E           {FND} Feature Token_Method not defined
E
E           -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
E           closing a file left open: /build/tmpyi73uuuh

According to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687822 we are likely missing two folders, voices and dict. But for us the festival integration is out of scope for now. The espeak backend works and it's what we are using.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mweinelt mweinelt force-pushed the mweinelt:python/phonemizer branch from 10be9fb to 32db24b Nov 14, 2020
@mweinelt mweinelt changed the title festival: init at 2.5.0; python3Packages.phonemizer: init at 2.2.1 python3Packages.phonemizer: init at 2.2.1 Nov 14, 2020

meta = with lib; {
homepage = "https://github.com/bootphon/phonemizer";
description = "Simple text to phones converter for multiple languages";

This comment has been minimized.

@7c6f434c

7c6f434c Nov 14, 2020
Member

to phonemes, II assume?

This comment has been minimized.

@mweinelt

mweinelt Nov 14, 2020
Author Member

Yikes! Copied from https://github.com/bootphon/phonemizer.

They even talk about "phones" in the issues, I'm not qualified to doubt their description.

This comment has been minimized.

@7c6f434c

7c6f434c Nov 14, 2020
Member

The name and the stated purpose kind of hint towards phonemes, but yeah, checking that they do not indeed produce different phones of the same phoneme under different conditions would be a lot of work, so we have to believe the upstream

@mweinelt mweinelt force-pushed the mweinelt:python/phonemizer branch from 32db24b to 582a7f4 Nov 14, 2020
@mweinelt mweinelt force-pushed the mweinelt:python/phonemizer branch from 582a7f4 to 8578fb3 Nov 14, 2020
@7c6f434c 7c6f434c merged commit 3e5039c into NixOS:master Nov 14, 2020
17 checks passed
17 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8578fb3"; rev="8578fb314495b24e1bb3b533d18542459f6031c3"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8578fb3"; rev="8578fb314495b24e1bb3b533d18542459f6031c3"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8578fb3"; rev="8578fb314495b24e1bb3b533d18542459f6031c3"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8578fb3"; rev="8578fb314495b24e1bb3b533d18542459f6031c3"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8578fb3"; rev="8578fb314495b24e1bb3b533d18542459f6031c3"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8578fb3"; rev="8578fb314495b24e1bb3b533d18542459f6031c3"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8578fb3"; rev="8578fb314495b24e1bb3b533d18542459f6031c3"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mweinelt mweinelt deleted the mweinelt:python/phonemizer branch Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.