awscli2: fix completion #103718
Merged
awscli2: fix completion #103718
Conversation
|
Avoid merges, rebase instead and squash the commits. |
|
Other than that, the change looks good to me. I am however unfamiliar with installing completions. |
Generate index file for shell completion Fix #103709 See-also: https://github.com/Homebrew/homebrew-core/pull/57547/files
Thx @FRidh for letting me know of the git strategy, I've squashed the commits. |
|
Tested - works! |
peterhoeg
merged commit 8582f5d
into
NixOS:master
19 checks passed
19 checks passed
grahamcofborg-eval-darwin
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./pkgs/t
Details
grahamcofborg-eval-nixos
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list-no-aliases
nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Generate index file for shell completion
Fix #103709
See-also: https://github.com/Homebrew/homebrew-core/pull/57547/files
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)