Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscli2: fix completion #103718

Merged
merged 1 commit into from Nov 23, 2020
Merged

awscli2: fix completion #103718

merged 1 commit into from Nov 23, 2020

Conversation

@qrevel
Copy link
Contributor

@qrevel qrevel commented Nov 13, 2020

Generate index file for shell completion

Fix #103709

See-also: https://github.com/Homebrew/homebrew-core/pull/57547/files

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@davegallant davegallant mentioned this pull request Nov 21, 2020
7 of 10 tasks complete
Copy link
Member

@FRidh FRidh left a comment

Avoid merges, rebase instead and squash the commits.

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 21, 2020

Other than that, the change looks good to me. I am however unfamiliar with installing completions.

Generate index file for shell completion

Fix #103709

See-also: https://github.com/Homebrew/homebrew-core/pull/57547/files
@qrevel qrevel force-pushed the qrevel:fix-aws-cli-completion branch from 44226ec to 54871c4 Nov 21, 2020
@qrevel
Copy link
Contributor Author

@qrevel qrevel commented Nov 21, 2020

Avoid merges, rebase instead and squash the commits.

Thx @FRidh for letting me know of the git strategy, I've squashed the commits.

@qrevel qrevel requested a review from FRidh Nov 21, 2020
@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Nov 23, 2020

Tested - works!

@peterhoeg peterhoeg merged commit 8582f5d into NixOS:master Nov 23, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
awscli2, awscli2.passthru.tests on aarch64-linux Failure
Details
awscli2, awscli2.passthru.tests on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="54871c4"; rev="54871c4ab89a092203ee01b36fe2768249a7857c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@qrevel qrevel deleted the qrevel:fix-aws-cli-completion branch Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.