Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] go_1_14: 1.14.9 -> 1.14.12, go_1_15: 1.15.2 -> 1.15.5 #103719

Merged
merged 6 commits into from Nov 14, 2020

Conversation

@RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Nov 13, 2020

(cherry picked from commit 1692a8a)

Motivation for this change

Backports #103649

Go 1.14.12 and 1.15.5 contain a fix for CVE-2020-28362.

Backporting this is a prerequisite for updating vulnerable go packages, such as go-ethereum.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@mdlayher mdlayher left a comment

LGTM

Copy link
Contributor

@zowoq zowoq left a comment

Please cherrypick each version bump.

e.g.
1.14.9 -> 1.14.10
1.14.10 -> 1.14.11
1.14.11 -> 1.14.12

See #97566 an an example.

zowoq added 6 commits Oct 14, 2020
(cherry picked from commit 4f282b1)
(cherry picked from commit 6084c2e)
(cherry picked from commit ffb658f)
(cherry picked from commit d1febbe)
(cherry picked from commit 1692a8a)
(cherry picked from commit a259136)
@RaghavSood RaghavSood force-pushed the RaghavSood:release-20.09 branch from 562e687 to 93d0659 Nov 14, 2020
@RaghavSood RaghavSood requested a review from zowoq Nov 14, 2020
@ofborg ofborg bot requested a review from mdlayher Nov 14, 2020
@RaghavSood RaghavSood changed the title [20.09] go_1_14: 1.14.11 -> 1.14.12, go_1_15: 1.15.4 -> 1.15.5 [20.09] go_1_14: 1.14.9 -> 1.14.12, go_1_15: 1.15.2 -> 1.15.5 Nov 14, 2020
@zowoq
zowoq approved these changes Nov 14, 2020
@zowoq zowoq merged commit 808f249 into NixOS:release-20.09 Nov 14, 2020
18 checks passed
18 checks passed
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
go_1_14, go_1_14.passthru.tests, go_1_15, go_1_15.passthru.tests on aarch64-linux Success
Details
go_1_14, go_1_14.passthru.tests, go_1_15, go_1_15.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d0659"; rev="93d06598b60696513bfd6cc5fe7fc7166a9d9ee5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d0659"; rev="93d06598b60696513bfd6cc5fe7fc7166a9d9ee5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d0659"; rev="93d06598b60696513bfd6cc5fe7fc7166a9d9ee5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d0659"; rev="93d06598b60696513bfd6cc5fe7fc7166a9d9ee5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d0659"; rev="93d06598b60696513bfd6cc5fe7fc7166a9d9ee5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d0659"; rev="93d06598b60696513bfd6cc5fe7fc7166a9d9ee5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d0659"; rev="93d06598b60696513bfd6cc5fe7fc7166a9d9ee5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.