Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] go_1_14: 1.14.8 -> 1.14.12 #103722

Merged
merged 4 commits into from Nov 14, 2020
Merged

Conversation

@RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Nov 13, 2020

(cherry picked from commit 1692a8a)

Motivation for this change

Backports #103649

Go 1.14.12 and 1.15.5 contain a fix for CVE-2020-28362.

Only 1.14.12 is backported as 20.03 does not include go 1.15

Backporting this is a prerequisite for updating vulnerable go packages, such as go-ethereum.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@RaghavSood RaghavSood changed the title go_1_14: 1.14.11 -> 1.14.12 [20.03] go_1_14: 1.14.11 -> 1.14.12 Nov 13, 2020
@ofborg ofborg bot added the 6.topic: golang label Nov 13, 2020
@ofborg ofborg bot requested review from Frostman, kalbasit, Mic92 and cstrahan Nov 13, 2020
Copy link
Contributor

@zowoq zowoq left a comment

Please cherrypick each version bump.

#103719 (review)

@RaghavSood RaghavSood force-pushed the RaghavSood:release-20.03 branch from 5b5d9ca to bb1dc61 Nov 14, 2020
@RaghavSood RaghavSood requested a review from zowoq Nov 14, 2020
zowoq added 4 commits Sep 10, 2020
(cherry picked from commit 6190615)
(cherry picked from commit 4f282b1)
(cherry picked from commit ffb658f)
(cherry picked from commit 1692a8a)
@RaghavSood RaghavSood force-pushed the RaghavSood:release-20.03 branch from bb1dc61 to 229b4fb Nov 14, 2020
@RaghavSood RaghavSood changed the title [20.03] go_1_14: 1.14.11 -> 1.14.12 [20.03] go_1_14: 1.14.8 -> 1.14.12 Nov 14, 2020
@zowoq
zowoq approved these changes Nov 14, 2020
@zowoq zowoq merged commit 7abaad0 into NixOS:release-20.03 Nov 14, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
go_1_14, go_1_14.passthru.tests on aarch64-linux Success
Details
go_1_14, go_1_14.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="229b4fb"; rev="229b4fb9744d5d56a69074374517f7bf6bc83676"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="229b4fb"; rev="229b4fb9744d5d56a69074374517f7bf6bc83676"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="229b4fb"; rev="229b4fb9744d5d56a69074374517f7bf6bc83676"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="229b4fb"; rev="229b4fb9744d5d56a69074374517f7bf6bc83676"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="229b4fb"; rev="229b4fb9744d5d56a69074374517f7bf6bc83676"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="229b4fb"; rev="229b4fb9744d5d56a69074374517f7bf6bc83676"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="229b4fb"; rev="229b4fb9744d5d56a69074374517f7bf6bc83676"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants