Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontconfig: build manpages, install them in bin output #103725

Merged
merged 1 commit into from Nov 18, 2020

Conversation

@erictapen
Copy link
Member

@erictapen erictapen commented Nov 13, 2020

Motivation for this change

Generate manpages for fontconfig and install them in the bin output.

Closes #103695 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@vcunat
vcunat approved these changes Nov 14, 2020
Copy link
Member

@vcunat vcunat left a comment

OK, though I'm not sure about the man3 part... perhaps that's not really suitable there. (It's over two hundred pages; there might be noticeable overhead in some cases. And they seem less likely to be useful.)

@ofborg ofborg bot requested a review from vcunat Nov 14, 2020
We exclude man3, as it is pretty large and probably not so relevant.
@erictapen erictapen force-pushed the erictapen:fontconfig-manpages branch from b6c589f to 0121b40 Nov 14, 2020
@erictapen
Copy link
Member Author

@erictapen erictapen commented Nov 14, 2020

@vcunat agreed. I removed section 3.

@FRidh FRidh merged commit 6463b27 into NixOS:staging Nov 18, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
fontconfig, fontconfig.passthru.tests on aarch64-linux Success
Details
fontconfig, fontconfig.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0121b40"; rev="0121b40196eaf467ae0bec38800c1aaba0a3e2f5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0121b40"; rev="0121b40196eaf467ae0bec38800c1aaba0a3e2f5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0121b40"; rev="0121b40196eaf467ae0bec38800c1aaba0a3e2f5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0121b40"; rev="0121b40196eaf467ae0bec38800c1aaba0a3e2f5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0121b40"; rev="0121b40196eaf467ae0bec38800c1aaba0a3e2f5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0121b40"; rev="0121b40196eaf467ae0bec38800c1aaba0a3e2f5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0121b40"; rev="0121b40196eaf467ae0bec38800c1aaba0a3e2f5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants