Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide libwpe for webkitgtk in Wayland #103728

Open
wants to merge 3 commits into
base: master
from

Conversation

@matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Nov 13, 2020

When running in a Wayland environment, webkitgtk needs the libwpe backend to implement accelerated compositing on Wayland. Without this, you can get errors like:

Cannot get default EGL display: EGL_BAD_PARAMETER

Webkitgtk is supposed to gracefully disable AC when this happens, but this doesn't appear to be working for me. You can manually disable AC with WEBKIT_DISABLE_COMPOSITING_MODE=1.

See https://gitweb.gentoo.org/repo/gentoo.git/tree/net-libs/webkit-gtk/webkit-gtk-2.28.4.ebuild#n222 for some idea of how Gentoo handles this. In nixpkgs, I think it's a good idea to just provide libwpe everywhere, regardless of whether the user has configured "wayland" or not.

Other discussions:

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 13, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/install-nixos-on-laptop-im-failing-hard/6955/5

Copy link
Contributor

@jtojnar jtojnar left a comment

Weird, I thought we had already wpewebkit PR but cannot find it.

pkgs/development/libraries/libwpe/default.nix Outdated Show resolved Hide resolved
@matthewbauer
Copy link
Member Author

@matthewbauer matthewbauer commented Nov 13, 2020

Weird, I thought we had already wpewebkit PR but cannot find it.

Ah I had opened it in #96140 but forgot about it! Anyway this should be find to merge first, especially if it resolves the epiphany on wayland issue.

description = "General-purpose library for WPE WebKit";
license = licenses.bsd2;
homepage = "https://wpewebkit.org";
maintainers = [ maintainers.matthewbauer ];

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 23, 2020
Member

Suggested change
maintainers = [ maintainers.matthewbauer ];
maintainers = with maintainers; [ matthewbauer ];
description = "Freedesktop.org backend for WPE WebKit";
license = licenses.bsd2;
homepage = "https://wpewebkit.org";
maintainers = [ maintainers.matthewbauer ];

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 23, 2020
Member

Suggested change
maintainers = [ maintainers.matthewbauer ];
maintainers = with maintainers; [ matthewbauer ];
pkgs/development/libraries/libwpe/fdo.nix Outdated Show resolved Hide resolved
@matthewbauer matthewbauer force-pushed the matthewbauer:webkitgtk-with-libwpe branch from 182f9c6 to 2377726 Nov 23, 2020
@matthewbauer
Copy link
Member Author

@matthewbauer matthewbauer commented Nov 23, 2020

Updated

@matthewbauer
Copy link
Member Author

@matthewbauer matthewbauer commented Nov 23, 2020

@GrahamcOfBorg build epiphany

];

nativeBuildInputs = [
pkgconfig

This comment has been minimized.

@jtojnar

jtojnar Nov 23, 2020
Contributor

eval error

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 28, 2020

@matthewbauer Can you fix the eval error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.