bluespec unstable-2020.02.09 -> unstable-2020.11.04

[jcumming]

Continue on with #84142

• (thanks @flokli).
• a small patch to install the STP stub (upstream PR: B-Lang-org/bsc#278)
• set LD_LIBRARY_PATH during build so that bsc finishes bootstrapping
• use nixpkgs yices.src instead of a subrepo
• match yices gmp-static idiom

I ran this through https://github.com/jcumming/bsc-testsuite, and the 13 failures appear to mostly be nixos-isms.

I'm waiting on to see if upstream takes the patch, so I can drop it from this PR.

Motivation for this change

Update bluespec to latest version.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.
• ran bsc-testsuite

[jcumming]

FWIW; is there a better way to do this?

[flokli]

Does the source code need to be there, or can we patch the build system to accept an external yices, and set paths to header files and libraries (or have the buildsystem ask pkgconfig for it)

[jcumming]

Good point. I'll try that.

[thoughtpolice]

Thanks! If you can just please fix the trailing whitespace/editorconfig issues, I think we can go ahead and merge this and keep clean up things in future PRs. Otherwise this looks fine to me, and it's good to keep bluespec working for everyone...

[thoughtpolice]

@ofborg build bluespec

[thoughtpolice]

@jcumming I've pushed this commit, along with a fix for an incorrect sha256 hash, as part of d402d91 (with credit to you, of course.) I suspect the hash thing happened because source attributes are fixed-output, so if you download the source once you can screw up the hash later and it'll still succeed, unfortunately.

I've tested this package on my Ryzen machine however and it seems to build just fine. Let's keep submitting any improvements incrementally, either to upstream or here! Thanks for your help.