Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdbm: Fix multiple definitions error when building with clang #103732

Merged
merged 1 commit into from Nov 18, 2020

Conversation

@kampka
Copy link
Contributor

@kampka kampka commented Nov 13, 2020

Motivation for this change

Building gdbm with clang fails with

/nix/store/0zjjw5q49symj3s4g4axqgrq7jil1hk0-binutils-2.31.1/bin/ld: ./libgdbmapp.a(parseopt.o):/build/gdbm-1.18.1/src/parseopt.c:259: multiple definition of `parseopt_program_args'; gdbmtool.o
:/build/gdbm-1.18.1/src/gdbmtool.c:1539: first defined here                                     
/nix/store/0zjjw5q49symj3s4g4axqgrq7jil1hk0-binutils-2.31.1/bin/ld: ./libgdbmapp.a(parseopt.o):/build/gdbm-1.18.1/src/parseopt.c:258: multiple definition of `parseopt_program_doc'; gdbmtool.o:
/build/gdbm-1.18.1/src/gdbmtool.c:1538: first defined here    

This patch fixes that by removing the unnecessary definitions.
The patch has also been send upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@kampka kampka changed the base branch from master to staging Nov 13, 2020
@kampka kampka force-pushed the kampka:gdbm-clang branch from 4352a1c to 8688665 Nov 13, 2020
@ofborg ofborg bot requested a review from vrthra Nov 13, 2020
@zowoq zowoq removed their request for review Nov 15, 2020
@FRidh FRidh merged commit 9451ae5 into NixOS:staging Nov 18, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
gdbm, gdbm.passthru.tests on aarch64-linux Success
Details
gdbm, gdbm.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8688665"; rev="868866537ddc1d8366ff7ff05407e61796093396"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8688665"; rev="868866537ddc1d8366ff7ff05407e61796093396"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8688665"; rev="868866537ddc1d8366ff7ff05407e61796093396"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8688665"; rev="868866537ddc1d8366ff7ff05407e61796093396"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8688665"; rev="868866537ddc1d8366ff7ff05407e61796093396"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8688665"; rev="868866537ddc1d8366ff7ff05407e61796093396"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8688665"; rev="868866537ddc1d8366ff7ff05407e61796093396"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants