Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libreoffice-qt: wrap application #103734

Merged
merged 1 commit into from Nov 14, 2020
Merged

Conversation

@jmpunkt
Copy link
Contributor

@jmpunkt jmpunkt commented Nov 13, 2020

Libreoffice-qt is not wrapped, thus does not launch. Notice that
wrapQtQAppsHook is used manually since all executables are shell
scripts which are not wrapped automatically.

Motivation for this change

Libreoffice-qt currently does not start on 20.09 or master due to missing Qt wrapping.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Libreoffice-qt is not wrapped, thus does not launch. Notice that
wrapQtQAppsHook is used manually since all executables are shell
scripts which are not wrapped automatically.
@ofborg ofborg bot requested a review from 7c6f434c Nov 13, 2020
@7c6f434c 7c6f434c merged commit e3a8851 into NixOS:master Nov 14, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
libreoffice-qt, libreoffice-qt.passthru.tests on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ea12d88"; rev="ea12d880e0fd9b2f08f4f974c8af849bfd59a230"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ea12d88"; rev="ea12d880e0fd9b2f08f4f974c8af849bfd59a230"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ea12d88"; rev="ea12d880e0fd9b2f08f4f974c8af849bfd59a230"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ea12d88"; rev="ea12d880e0fd9b2f08f4f974c8af849bfd59a230"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ea12d88"; rev="ea12d880e0fd9b2f08f4f974c8af849bfd59a230"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ea12d88"; rev="ea12d880e0fd9b2f08f4f974c8af849bfd59a230"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ea12d88"; rev="ea12d880e0fd9b2f08f4f974c8af849bfd59a230"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libreoffice-qt, libreoffice-qt.passthru.tests on x86_64-linux Success
Details
@jmpunkt jmpunkt deleted the jmpunkt:libreoffice-qt-wrap branch Nov 14, 2020
@jmpunkt jmpunkt mentioned this pull request Nov 14, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.