Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-policy-agent: move to go modules #103741

Merged
merged 2 commits into from Nov 17, 2020
Merged

open-policy-agent: move to go modules #103741

merged 2 commits into from Nov 17, 2020

Conversation

@06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented Nov 13, 2020

Motivation for this change

Move to buildGoModule, use an array for buildFlagsArray, and add a longDescription

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
06kellyjac added 2 commits Nov 13, 2020
Move from buildGoPackage to buildGoModule since opa is a go module.
Added a long description of OPA
@06kellyjac
Copy link
Contributor Author

@06kellyjac 06kellyjac commented Nov 13, 2020

Result of nixpkgs-review pr 103741 1

1 package built:
  • open-policy-agent
@kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 13, 2020

@GrahamcOfBorg build open-policy-agent

@srenatus
Copy link
Contributor

@srenatus srenatus commented Nov 16, 2020

Tried this locally (osx), works great 🎉 Thank you!

@nlewo
Copy link
Member

@nlewo nlewo commented Nov 17, 2020

Thanks everyone!

@nlewo nlewo merged commit 8fc335c into NixOS:master Nov 17, 2020
21 of 22 checks passed
21 of 22 checks passed
tests
Details
action
Details
open-policy-agent on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c4742c"; rev="4c4742cb583fcb98b582c1c1159bc98b30214486"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c4742c"; rev="4c4742cb583fcb98b582c1c1159bc98b30214486"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c4742c"; rev="4c4742cb583fcb98b582c1c1159bc98b30214486"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c4742c"; rev="4c4742cb583fcb98b582c1c1159bc98b30214486"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c4742c"; rev="4c4742cb583fcb98b582c1c1159bc98b30214486"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c4742c"; rev="4c4742cb583fcb98b582c1c1159bc98b30214486"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4c4742c"; rev="4c4742cb583fcb98b582c1c1159bc98b30214486"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
open-policy-agent on aarch64-linux Success
Details
open-policy-agent on x86_64-linux Success
Details
open-policy-agent, open-policy-agent.passthru.tests on aarch64-linux Success
Details
open-policy-agent, open-policy-agent.passthru.tests on x86_64-linux Success
Details
@06kellyjac 06kellyjac deleted the 06kellyjac:opa_cleanup branch Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants