Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate py37 programs to py3 #103742

Merged
merged 6 commits into from Nov 28, 2020
Merged

Migrate py37 programs to py3 #103742

merged 6 commits into from Nov 28, 2020

Conversation

@freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 13, 2020

Motivation for this change

Some programs in nixpkgs were using explicitly python37, and they also work with latest branch, so here are some "migrations" that seem correct.

I started the binaries they look ok

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@@ -937,7 +937,7 @@ in

iamy = callPackage ../tools/admin/iamy { };

azure-cli = callPackage ../tools/admin/azure-cli { python = python37; };
azure-cli = callPackage ../tools/admin/azure-cli { python = python3; };

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 23, 2020
Member

Using python3 in the package is probably more straight forward.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 24, 2020

When trying to build this with nixpkgs-review I get several thousands rebuilds. Not sure what went wrong here.

@freezeboy
Copy link
Contributor Author

@freezeboy freezeboy commented Nov 24, 2020

@SuperSandro2000 azure-cli has its own package set.. maybe redundant with other azure-* packages by the way

@jonringer Do you know why there is a special python-package set ?

@freezeboy freezeboy force-pushed the freezeboy:migrate-py37-py3 branch from d755d9b to a8ca3e5 Nov 24, 2020
@freezeboy freezeboy mentioned this pull request Nov 24, 2020
5 of 10 tasks complete
@ofborg ofborg bot requested a review from jonringer Nov 24, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 24, 2020

@jonringer Do you know why there is a special python-package set ?

because the azure-cli lags 1-6 weeks behind most of the python azure sdk, or sometimes uses pre-releases for certain packages. azure-cli would essentially be unusable without it.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 24, 2020

azure-cli was kept at python37 originally because aiohttp didn't support it for the longest time

@freezeboy
Copy link
Contributor Author

@freezeboy freezeboy commented Nov 24, 2020

ok good to know

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 28, 2020

Result of nixpkgs-review pr 103742 run on x86_64-darwin 1

4 packages failed to build:
  • azure-cli
  • html5validator
  • manim
  • precice

manim download over 3000 tex packages. Not trying this one. Other are currently building manually to get some logs.

Edit: rebuild everything except mannim and it worked.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 103742 1

5 packages built:
  • azure-cli
  • html5validator
  • manim
  • precice
  • syncplay

@jonringer jonringer merged commit abfbb84 into NixOS:master Nov 28, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
azure-cli, azure-cli.passthru.tests, html5validator, html5validator.passthru.tests, manim, manim.passthru.tests, precice, precice.passthru.tests, syncplay, syncplay.passthru.tests on aarch64-linux Failure
Details
azure-cli, azure-cli.passthru.tests, html5validator, html5validator.passthru.tests, manim, manim.passthru.tests, precice, precice.passthru.tests, syncplay, syncplay.passthru.tests on x86_64-linux Unexpected error: command failed with exit code 1
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8ca3e5"; rev="a8ca3e505962921d071719c14daee23855443fdb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8ca3e5"; rev="a8ca3e505962921d071719c14daee23855443fdb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8ca3e5"; rev="a8ca3e505962921d071719c14daee23855443fdb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8ca3e5"; rev="a8ca3e505962921d071719c14daee23855443fdb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8ca3e5"; rev="a8ca3e505962921d071719c14daee23855443fdb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8ca3e5"; rev="a8ca3e505962921d071719c14daee23855443fdb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a8ca3e5"; rev="a8ca3e505962921d071719c14daee23855443fdb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@freezeboy freezeboy deleted the freezeboy:migrate-py37-py3 branch Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants