Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starboard-octant-plugin: init at 0.4.0 #103745

Merged
merged 1 commit into from Nov 23, 2020

Conversation

@06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented Nov 13, 2020

Motivation for this change

Add starboard-octant-plugin for use with octant
Since the plugin is a binary that talks to octant over gRPC I've allowed it to be packed in bin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@06kellyjac
Copy link
Contributor Author

@06kellyjac 06kellyjac commented Nov 13, 2020

Result of nixpkgs-review pr 103745 1

1 package built:
  • starboard-octant-plugin
@06kellyjac
Copy link
Contributor Author

@06kellyjac 06kellyjac commented Nov 17, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 17, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 17, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the needs_reviewer label Nov 17, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 23, 2020

Result of nixpkgs-review pr 103745 run on x86_64-linux 1

1 package built:
  • starboard-octant-plugin
@06kellyjac 06kellyjac force-pushed the 06kellyjac:starboard_octant_plugin branch from 6698738 to fb3f81b Nov 23, 2020
@06kellyjac
Copy link
Contributor Author

@06kellyjac 06kellyjac commented Nov 23, 2020

@SuperSandro2000 I rebased this one instead of #104371 by accident so both are now rebased 😅

@06kellyjac
Copy link
Contributor Author

@06kellyjac 06kellyjac commented Nov 23, 2020

Result of nixpkgs-review pr 103745 1

1 package built:
  • starboard-octant-plugin
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 23, 2020

Result of nixpkgs-review pr 103745 run on x86_64-darwin 1

1 package built:
  • starboard-octant-plugin
@SuperSandro2000 SuperSandro2000 merged commit 0c56403 into NixOS:master Nov 23, 2020
2 of 3 checks passed
2 of 3 checks passed
tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@06kellyjac 06kellyjac deleted the 06kellyjac:starboard_octant_plugin branch Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.