Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghidra: 9.1.2 -> 9.2 #103750

Merged
merged 1 commit into from Nov 23, 2020
Merged

ghidra: 9.1.2 -> 9.2 #103750

merged 1 commit into from Nov 23, 2020

Conversation

@GovanifY
Copy link
Member

@GovanifY GovanifY commented Nov 13, 2020

Motivation for this change

Version bump, also added myself as a maintainer. Depends on #103461 as I added myself to the maintainers-nix in the linked PR but it will probably be merged in the next few hours. Ofborg will fail until this PR is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@prusnak prusnak left a comment

Left few suggestions

pkgs/tools/security/ghidra/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/ghidra/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/ghidra/default.nix Outdated Show resolved Hide resolved
@GovanifY GovanifY force-pushed the GovanifY:ghidra-bump branch from 984bb52 to 80ceb60 Nov 14, 2020
@GovanifY
Copy link
Member Author

@GovanifY GovanifY commented Nov 18, 2020

@ofborg eval

@ofborg ofborg bot requested a review from ck3d Nov 18, 2020
@prusnak prusnak merged commit 5b6b477 into NixOS:master Nov 23, 2020
17 checks passed
17 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80ceb60"; rev="80ceb60cb16d63c9d31ed83ffdb505301aa15454"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80ceb60"; rev="80ceb60cb16d63c9d31ed83ffdb505301aa15454"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80ceb60"; rev="80ceb60cb16d63c9d31ed83ffdb505301aa15454"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80ceb60"; rev="80ceb60cb16d63c9d31ed83ffdb505301aa15454"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80ceb60"; rev="80ceb60cb16d63c9d31ed83ffdb505301aa15454"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80ceb60"; rev="80ceb60cb16d63c9d31ed83ffdb505301aa15454"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80ceb60"; rev="80ceb60cb16d63c9d31ed83ffdb505301aa15454"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.