Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cde-gtk-theme: add ability to override palette #103980

Closed
wants to merge 1 commit into from
Closed

cde-gtk-theme: add ability to override palette #103980

wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Nov 16, 2020

Motivation for this change

In the past to change colors of this theme you must do

 mkdir -p ~/.themes
 cp -Lr --no-preserve=mode /run/current-system/sw/share/themes/cdetheme ~/.themes/
 chmod +x ~/.themes/cdetheme/scripts/switchtheme
 cd ~/.themes/cdetheme/scripts/
 ./switchtheme ../palettes/Crimson.dp 4 0 0 false true false

Now its enough to do

cde-gtk-theme.override { palette = "Crimson"; numOfColors = 4; }

cc @romildo @NickHu @sauyon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/data/themes/cdetheme/default.nix Outdated Show resolved Hide resolved
cd cdetheme/scripts
substituteInPlace switchtheme \
--replace "Globals.themesrcdir=Globals.themedir" "Globals.themesrcdir='$HOME/cdetheme'" \
--replace "Globals.themedir=os.path.join(userhome,'.themes','cdetheme')" "Globals.themedir='$out/share/themes/cdetheme'" \
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 17, 2020

I am not sure here but shouldn't $out be evaluated here?

Copy link
Author

@ghost ghost Nov 17, 2020

@SuperSandro2000 Sorry, don't get it. It is evaluated here like expected

@ghost ghost closed this Nov 29, 2020
@ghost ghost reopened this Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant