Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amdvlk: 2020.Q4.4 -> 2020.Q4.5 #104267

Merged
merged 1 commit into from Nov 22, 2020
Merged

amdvlk: 2020.Q4.4 -> 2020.Q4.5 #104267

merged 1 commit into from Nov 22, 2020

Conversation

@Flakebi
Copy link
Member

@Flakebi Flakebi commented Nov 19, 2020

Motivation for this change

2020.Q4.4 didn’t age well, here goes 2020.Q4.5 with RX 6800 support: https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2020.Q4.5

Closure size compared to 2020.Q4.3 (which I still have installed):
/nix/store/nbvkmav524q20z0j1gm49xkda3yzl54d-amdvlk-2020.Q4.3 103230952 (~98.4 MiB)
/nix/store/da87cbkih1r856b96x3il2mgq9kkgym7-amdvlk-2020.Q4.5 104152552 (~99.3 MiB)

i686 version
/nix/store/64xxlxvy64fm59x96s6nka1xslxidp62-amdvlk-2020.Q4.3 108721400 (~103.7 MiB)
/nix/store/ziiyvi9xvl06yxdyh3xjh02fvqq4yvyr-amdvlk-2020.Q4.5 109737208 (~104.7 MiB)

Things done
  • Tested vkcube and Dota 2
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 19, 2020

@ofborg eval

Copy link
Member

@danieldk danieldk left a comment

LGTM

Result of nixpkgs-review pr 104267 1

2 packages built:
  • amdvlk
  • driversi686Linux.amdvlk
@danieldk danieldk merged commit b653e00 into NixOS:master Nov 22, 2020
19 checks passed
19 checks passed
tests tests
Details
action action
Details
amdvlk, amdvlk.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
amdvlk, amdvlk.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bd56b3"; rev="5bd56b350df5f465323cd7ba704de536230200da"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bd56b3"; rev="5bd56b350df5f465323cd7ba704de536230200da"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bd56b3"; rev="5bd56b350df5f465323cd7ba704de536230200da"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bd56b3"; rev="5bd56b350df5f465323cd7ba704de536230200da"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bd56b3"; rev="5bd56b350df5f465323cd7ba704de536230200da"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bd56b3"; rev="5bd56b350df5f465323cd7ba704de536230200da"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5bd56b3"; rev="5bd56b350df5f465323cd7ba704de536230200da"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Flakebi Flakebi deleted the Flakebi:amdvlk branch Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.