Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] mutt: 1.14.7 -> 2.0.2 #104422

Merged

Conversation

@stigtsp
Copy link
Member

@stigtsp stigtsp commented Nov 20, 2020

Motivation for this change

Backport of #104399, fixes CVE-2020-28896

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Cc: @matthiasbeyer

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit e9e003e)
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit 5848e98)
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit ad9256d)
@stigtsp stigtsp requested review from rnhmjoj and Ma27 Nov 20, 2020
@stigtsp stigtsp changed the title [20.09] mutt: 1.14.8 -> 2.0.2 [20.09] mutt: 1.14.7 -> 2.0.2 Nov 20, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 22, 2020

Result of nixpkgs-review pr 104422 1

2 packages built:
  • grepm
  • mutt (mutt-with-sidebar)
@mweinelt mweinelt merged commit 1f86723 into NixOS:release-20.09 Nov 22, 2020
18 checks passed
18 checks passed
action action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e205534"; rev="e2055348481a995eb0ec3059f6a4eed3dc002dbb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e205534"; rev="e2055348481a995eb0ec3059f6a4eed3dc002dbb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e205534"; rev="e2055348481a995eb0ec3059f6a4eed3dc002dbb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e205534"; rev="e2055348481a995eb0ec3059f6a4eed3dc002dbb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e205534"; rev="e2055348481a995eb0ec3059f6a4eed3dc002dbb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e205534"; rev="e2055348481a995eb0ec3059f6a4eed3dc002dbb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e205534"; rev="e2055348481a995eb0ec3059f6a4eed3dc002dbb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mutt, mutt.passthru.tests on aarch64-linux Success
Details
mutt, mutt.passthru.tests on x86_64-linux Success
Details
@stigtsp
Copy link
Member Author

@stigtsp stigtsp commented Nov 22, 2020

@mweinelt mutt probably shouldn't have been bumped, since 2.x introduces some breaking changes. (sorry, my mistake)

#104423 (comment)

Ok to revert the change and create a new PR apply the patch?

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 22, 2020

Uh yeah, I missed the major version bump. My bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.