Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lc3tools: init at 0.12 #104450

Merged
merged 1 commit into from Nov 29, 2020
Merged

lc3tools: init at 0.12 #104450

merged 1 commit into from Nov 29, 2020

Conversation

@anna328p
Copy link
Member

@anna328p anna328p commented Nov 21, 2020

Motivation for this change

Added the lc3tools toolchain and emulator for the LC-3 architecture.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@anna328p
Copy link
Member Author

@anna328p anna328p commented Nov 21, 2020

I think ofborg is broken?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 21, 2020

I think ofborg is broken?

Try rebasing on master to catch f75c875

@anna328p
Copy link
Member Author

@anna328p anna328p commented Nov 21, 2020

I think ofborg is broken?

Try rebasing on master to catch f75c875

@SuperSandro2000 Done

@anna328p
Copy link
Member Author

@anna328p anna328p commented Nov 21, 2020

...still seems broken

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 21, 2020

This is a regression, someone pushed a change that broke evaluation.

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 21, 2020

1 similar comment
@FRidh
Copy link
Member

@FRidh FRidh commented Nov 21, 2020

@anna328p
Copy link
Member Author

@anna328p anna328p commented Nov 22, 2020

rebased and checks pass now!

version = "0.12";

src = fetchurl {
url = "https://highered.mheducation.com/sites/dl/free/0072467509/104652/lc3tools_v12.zip";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 23, 2020

Is there any URL which uses the version? Otherwise auto updates do not work.

Copy link
Member Author

@anna328p anna328p Nov 23, 2020

There hasn't been an update since 2008. I can potentially ask Lumetta for newer source (he's my professor).

Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 24, 2020

I am not sure what to do here but packaging software from 2008 does not feel right to me.

Copy link
Member Author

@anna328p anna328p Nov 26, 2020

If it still builds, why not?

Copy link
Member

@Ma27 Ma27 left a comment

While I'm actually fine with adding the package itself, please make sure that the executables are installed into $out/bin.

@anna328p
Copy link
Member Author

@anna328p anna328p commented Nov 29, 2020

While I'm actually fine with adding the package itself, please make sure that the executables are installed into $out/bin.

Done.

Ma27
Ma27 approved these changes Nov 29, 2020
@Ma27 Ma27 merged commit 91e6ee0 into NixOS:master Nov 29, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants