Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libreoffice: improve codec support #104473

Merged
merged 1 commit into from Nov 29, 2020
Merged

libreoffice: improve codec support #104473

merged 1 commit into from Nov 29, 2020

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 21, 2020

Right now libreoffice cannot play mp4/h264 videos,
which is needed if your $genius professor publishes lectures
as powerpoint with embedded videos.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
++ (with gst_all_1; [ gstreamer gst-plugins-base gst-plugins-good ])
++ (with gst_all_1; [
gstreamer
gst-plugins-base gst-plugins-good gst-plugins-bad gst-plugins-ugly
Copy link
Member Author

@Mic92 Mic92 Nov 21, 2020

This is just setting $GST_PLUGIN_SYSTEM_PATH_1_0 correctly, so not a lot to it

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 23, 2020

Can you rebase this branch on master to fix the eval error?

@Mic92
Copy link
Member Author

@Mic92 Mic92 commented Nov 23, 2020

Done.

Right now libreoffice cannot play mp4/h264 videos,
which is needed if your $genius professor publishes lectures
as powerpoint with embedded videos.
@ofborg ofborg bot requested a review from 7c6f434c Nov 29, 2020
@7c6f434c 7c6f434c merged commit da817c1 into NixOS:master Nov 29, 2020
19 of 20 checks passed
@Mic92 Mic92 deleted the libreoffice branch Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants