Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "haskellPackages.trifecta: dontCheck on darwin" #104535

Merged
merged 1 commit into from Nov 22, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 21, 2020

This reverts commit 10e961c.

Fixed by 473b341.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This reverts commit 10e961c.

Fixed by 473b341.
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Nov 22, 2020

@GrahamcOfBorg build haskellPackages.trifecta

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Nov 22, 2020

Hmm, the ofborg darwin job does not seem to be starting :-\

@zowoq I trust that you actually built this on Darwin, so I'll go ahead and merge it in. Thanks for updating this!

@cdepillabout cdepillabout merged commit 4fea8c8 into NixOS:haskell-updates Nov 22, 2020
19 of 20 checks passed
19 of 20 checks passed
tests
Details
action
Details
haskellPackages.trifecta on x86_64-darwin
Details
haskellPackages.trifecta on aarch64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eeb7216"; rev="eeb7216d712e3be46c54b129704c4b601afb9095"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eeb7216"; rev="eeb7216d712e3be46c54b129704c4b601afb9095"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eeb7216"; rev="eeb7216d712e3be46c54b129704c4b601afb9095"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eeb7216"; rev="eeb7216d712e3be46c54b129704c4b601afb9095"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eeb7216"; rev="eeb7216d712e3be46c54b129704c4b601afb9095"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eeb7216"; rev="eeb7216d712e3be46c54b129704c4b601afb9095"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eeb7216"; rev="eeb7216d712e3be46c54b129704c4b601afb9095"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
haskellPackages.trifecta on x86_64-linux Success
Details
@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Nov 22, 2020

ofborg darwin job does not seem to be starting

ofborg is still queuing jobs for darwin but the builder been offline for a couple of months.

@zowoq zowoq deleted the zowoq:trifecta branch Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.