Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.tart: unmark as broken #104541

Merged
merged 1 commit into from Nov 22, 2020

Conversation

@SenchoPens
Copy link

@SenchoPens SenchoPens commented Nov 21, 2020

Motivation for this change

Dependency issues for this package have been fixed in the latest release.
See jtdaugherty/tart#12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I can not understand how I can test the package using sandboxing or just with nix build .#haskellPackages.tart without running hackage2nix (which I did not do), but for the record I succesfully built the new release manually and run the program.

@maralorn
Copy link
Contributor

@maralorn maralorn commented Nov 22, 2020

Yeah, for this use case you need to run hackage2nix, I guess. Let's just wait the 1h until the cronjob does it for us. Feel free to ping me again if no one merges this tomorrow.

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Nov 22, 2020

I think the cronjob has now run, and tart has been bumped to 0.3 on haskell-updates. I'll go ahead and merge this in.

Thanks for the update @SenchoPens!

@cdepillabout cdepillabout merged commit e69b2a0 into NixOS:haskell-updates Nov 22, 2020
16 checks passed
16 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91781ab"; rev="91781abf2de38ed8c6e84740825fdafab428161d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91781ab"; rev="91781abf2de38ed8c6e84740825fdafab428161d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91781ab"; rev="91781abf2de38ed8c6e84740825fdafab428161d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91781ab"; rev="91781abf2de38ed8c6e84740825fdafab428161d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91781ab"; rev="91781abf2de38ed8c6e84740825fdafab428161d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91781ab"; rev="91781abf2de38ed8c6e84740825fdafab428161d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91781ab"; rev="91781abf2de38ed8c6e84740825fdafab428161d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@SenchoPens
Copy link
Author

@SenchoPens SenchoPens commented Nov 22, 2020

Thank you guys! Next time I'll try to run hackage2nix myself, just was a little confused of the whole process as it's my first commit into nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.