Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSH HPN: Update sha256 checksum of the distribution file #104568

Closed
wants to merge 1 commit into from

Conversation

@wahjava
Copy link
Contributor

@wahjava wahjava commented Nov 22, 2020

Motivation for this change

Upstream rerolled the tag few days ago causing:

hash mismatch in fixed-output derivation '/nix/store/b4ix0j1rii8b50drykz25pxmspvff7w1-hpn-KitchenSink-8_4_P1.tar.gz':
  wanted: sha256:06mr2q8d9kbj145r7mzmpm3a4ilnssibwlbjyy0bjsqrqnrll3zl
  got:    sha256:1x2afjy1isslbg7qlvhhs4zhj2c8q2h1ljz0fc5b4h9pqcm9j540
cannot build derivation '/nix/store/qcmin04gmx249gc5nlscm8bw36aqyw1d-openssh-8.4p1.drv': 1 dependencies couldn't be built
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lukegb
lukegb approved these changes Nov 23, 2020
@ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 23, 2020

Can you please fix the commit message to match CONTRIBUTING.MD?

Also, might I ask if and why you use this instead of regular openssh?

@wahjava wahjava force-pushed the wahjava:openssh-hpn84p1-reroll branch from 9a94b72 to d1d6922 Nov 23, 2020
@wahjava
Copy link
Contributor Author

@wahjava wahjava commented Nov 23, 2020

Can you please fix the commit message to match CONTRIBUTING.MD?

Sorry, and sure, I have made it similar to f8473b1. Please let me know if this is still not right.

Also, might I ask if and why you use this instead of regular openssh?

Because it provides better performance for file transfers, which I often use ssh for.

Also, while I'm here, I wonder if maintainers are open to offer a knob (or option) for experimental xmss key support present in OpenSSH ? For now, I use following overlay (inspired from FreeBSD port) and seems to work fine:

self: super:
{
  openssh_xmss = super.openssh_hpn.overrideAttrs (old: {
    postConfigure = ''echo "#define WITH_XMSS 1" >>config.h'';
  });
}

Thanks!

@ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 24, 2020

Looks like this is a duplicate of #103803. Sorry I didn't notice earlier.

Did you benchmark the difference between regular ssh and hpn?

@ajs124 ajs124 mentioned this pull request Nov 24, 2020
1 of 10 tasks complete
@SuperSandro2000
Copy link
Contributor

@SuperSandro2000 SuperSandro2000 commented Nov 24, 2020

I decided to merge the other PR because it was older.

@wahjava
Copy link
Contributor Author

@wahjava wahjava commented Nov 24, 2020

Looks like this is a duplicate of #103803. Sorry I didn't notice earlier.

No problems. It seems I failed to search too. Sorry about that.

Did you benchmark the difference between regular ssh and hpn?

I didn't benchmark (or record results) systematically, but at least when I started using couple of years ago, I found it better over high latency links (> 200ms RTT in my case), so I stuck with it.

@wahjava wahjava deleted the wahjava:openssh-hpn84p1-reroll branch Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.