Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yed: unmark broken #104572

Open
wants to merge 1 commit into
base: master
from
Open

yed: unmark broken #104572

wants to merge 1 commit into from

Conversation

@r-burns
Copy link
Contributor

@r-burns r-burns commented Nov 22, 2020

Motivation for this change

This was showing eval failures during nixpkgs-review on unrelated packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@r-burns r-burns force-pushed the r-burns:yed branch from b9d0d02 to 5e37b9b Nov 22, 2020
@r-burns r-burns force-pushed the r-burns:yed branch from 5e37b9b to 34c7fbe Nov 23, 2020
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 23, 2020

It's good now, only the commit message should be rewritten. Because this is not going to be a achange in the content of the commit I suspect GitHub won't notify me upon your force push, so please notify me when that's done.

@@ -50,6 +50,7 @@ let

passthru = {
home = jdk;
inherit gtk3;

This comment has been minimized.

@doronbehar

doronbehar Nov 23, 2020
Contributor

Oh and please add a comment here explaining the situation, and indicating that gtk3 is not an input of this package.

@r-burns r-burns mentioned this pull request Nov 23, 2020
1 of 10 tasks complete
@veprbl
Copy link
Member

@veprbl veprbl commented Nov 23, 2020

Adding gtk3 to jre.passthru does not fix yed on darwin, right?

@r-burns r-burns force-pushed the r-burns:yed branch from 34c7fbe to 3de7f6d Nov 24, 2020
@r-burns
Copy link
Contributor Author

@r-burns r-burns commented Nov 24, 2020

@doronbehar Let me know if that's more what you had in mind

@r-burns
Copy link
Contributor Author

@r-burns r-burns commented Nov 24, 2020

@veprbl I don't use yed but as far as I can tell I'm able to run the application and basic stuff seems to work

@veprbl
Copy link
Member

@veprbl veprbl commented Nov 24, 2020

@veprbl I don't use yed but as far as I can tell I'm able to run the application and basic stuff seems to work

Then we could unset yed.meta.broken and be done with it.

@r-burns
Copy link
Contributor Author

@r-burns r-burns commented Nov 24, 2020

D'oh, you are right. I don't know why I didn't realize that.

@r-burns r-burns force-pushed the r-burns:yed branch from 3de7f6d to fa9850e Nov 24, 2020
@r-burns r-burns changed the title yed: fix eval on darwin yed: unmark broken Nov 24, 2020
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 24, 2020

I don't understand what is the conclusion reached.

@r-burns
Copy link
Contributor Author

@r-burns r-burns commented Nov 24, 2020

Apparently the gtk3 input isn't needed on darwin, if I unmark it as broken it just works 🤷

@veprbl
Copy link
Member

@veprbl veprbl commented Nov 24, 2020

Probably the gtk3 dependency is optional. I would guess it's used to provide a system file chooser dialog and the rest is done using some java libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.