Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.faraday: 0.7.0 → 0.7.2 #104573

Merged
merged 1 commit into from Nov 23, 2020
Merged

ocamlPackages.faraday: 0.7.0 → 0.7.2 #104573

merged 1 commit into from Nov 23, 2020

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 22, 2020

Motivation for this change

Use Dune 2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Nov 23, 2020

@GrahamcOfBorg build ocamlPackages.faraday ocamlPackages.farfadet ocamlPackages.httpaf

Copy link
Member

@bcdarwin bcdarwin left a comment

Diff looks fine to me.

@vbgl vbgl merged commit c476262 into NixOS:master Nov 23, 2020
18 checks passed
18 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e2bc6c"; rev="2e2bc6ca943d1e3895baec5b1c95f153b33568d0"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e2bc6c"; rev="2e2bc6ca943d1e3895baec5b1c95f153b33568d0"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e2bc6c"; rev="2e2bc6ca943d1e3895baec5b1c95f153b33568d0"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e2bc6c"; rev="2e2bc6ca943d1e3895baec5b1c95f153b33568d0"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e2bc6c"; rev="2e2bc6ca943d1e3895baec5b1c95f153b33568d0"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e2bc6c"; rev="2e2bc6ca943d1e3895baec5b1c95f153b33568d0"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e2bc6c"; rev="2e2bc6ca943d1e3895baec5b1c95f153b33568d0"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocamlPackages.faraday, ocamlPackages.farfadet, ocamlPackages.httpaf on aarch64-linux Success
Details
ocamlPackages.faraday, ocamlPackages.farfadet, ocamlPackages.httpaf on x86_64-linux Success
Details
@vbgl vbgl deleted the vbgl:ocaml-faraday-0.7.2 branch Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.