Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u9fs: 20110513 -> unstable-2020-11-21 #104576

Merged
merged 1 commit into from Nov 22, 2020
Merged

u9fs: 20110513 -> unstable-2020-11-21 #104576

merged 1 commit into from Nov 22, 2020

Conversation

@siraben
Copy link
Contributor

@siraben siraben commented Nov 22, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@siraben
Copy link
Contributor Author

@siraben siraben commented Nov 22, 2020

Result of nixpkgs-review pr 104576 1

1 package built:
  • u9fs
pkgs/servers/u9fs/default.nix Show resolved Hide resolved
description = "Serve 9P from Unix";
homepage = "http://plan9.bell-labs.com/magic/man2html/4/u9fs";
license = licenses.free;
maintainers = [ maintainers.ehmry ];

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 22, 2020
Contributor

Suggested change
maintainers = [ maintainers.ehmry ];
maintainers = with maintainers; [ ehmry ];

This comment has been minimized.

@siraben

siraben Nov 22, 2020
Author Contributor

Is this preferred?

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 22, 2020
Contributor

it makes changing maintainers easier. I prefer it.

@SuperSandro2000
Copy link
Contributor

@SuperSandro2000 SuperSandro2000 commented Nov 22, 2020

@ehmry because ofborg is having problems.

@ehmry ehmry merged commit 8a4cf08 into NixOS:master Nov 22, 2020
9 of 12 checks passed
9 of 12 checks passed
tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
grahamcofborg-eval Complete, with errors
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85d7ed"; rev="a85d7edd489c74a3fffce4b99a4cfa0f2dcff811"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85d7ed"; rev="a85d7edd489c74a3fffce4b99a4cfa0f2dcff811"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85d7ed"; rev="a85d7edd489c74a3fffce4b99a4cfa0f2dcff811"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85d7ed"; rev="a85d7edd489c74a3fffce4b99a4cfa0f2dcff811"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85d7ed"; rev="a85d7edd489c74a3fffce4b99a4cfa0f2dcff811"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@siraben siraben deleted the siraben:u9fs-update branch Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.