Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseaudio: 13.0 -> 14.0 #105275

Merged
merged 2 commits into from Dec 7, 2020
Merged

pulseaudio: 13.0 -> 14.0 #105275

merged 2 commits into from Dec 7, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 28, 2020

Motivation for this change

https://www.freedesktop.org/wiki/Software/PulseAudio/Notes/14.0/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • enlightenment
    • mpd
    • plasma5
    • xfce
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
Copy link
Member

ajs124 commented Nov 28, 2020

Reading through the changelog, this might warrant a release notes entry, linking to the changelog.

Also, they have a meson build system now, which we'll want/need to switch to in 15.0

@lukegb
Copy link
Contributor Author

lukegb commented Nov 28, 2020

Yeah, I've avoided making this PR also switch to meson because of the issue mentioned in the release notes (it'll forget user preferences: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/1062)

@lukegb
Copy link
Contributor Author

lukegb commented Nov 29, 2020

Had problems running the tests against the staging branch, but ran them against master with the commit cherry-picked:

[lukegb@whitby:~/nixpkgs-pa14]$ nix-build nixos/tests/{enlightenment,plasma5,xfce,mpd}.nix
trace: warning: The option `services.xserver.displayManager.lightdm.autoLogin.user' defined in `<unknown-file>' has been renamed to `services.xserver.displayManager.autoLogin.user'.
trace: warning: The option `services.xserver.displayManager.lightdm.autoLogin.enable' defined in `<unknown-file>' has been renamed to `services.xserver.displayManager.autoLogin.enable'.
/nix/store/wqm8irhbf2l2k7xkp5i6isg60dmibh9k-vm-test-run-enlightenment
/nix/store/inv4d1ldgivlrk76lbk62gcbgs4gpr7j-vm-test-run-plasma5
/nix/store/qwpbdl0xyk3bxq1y0nl0zybaiv3yx601-vm-test-run-xfce
/nix/store/z68c3y656w7l1c9fwwccih0yag5m8ngx-vm-test-run-mpd

@lukegb
Copy link
Contributor Author

lukegb commented Nov 29, 2020

Rebased onto staging again to pull in 31dfbca.

@lukegb
Copy link
Contributor Author

lukegb commented Nov 29, 2020

[lukegb@whitby:~/nixpkgs-pa14]$ git describe
18.09-beta-104084-gd29428523ee

[lukegb@whitby:~/nixpkgs-pa14]$ nix-build nixos/tests/{enlightenment,plasma5,xfce,mpd}.nix 
trace: warning: The option `services.xserver.displayManager.lightdm.autoLogin.user' defined in `<unknown-file>' has been renamed to `services.xserver.displayManager.autoLogin.user'.
trace: warning: The option `services.xserver.displayManager.lightdm.autoLogin.enable' defined in `<unknown-file>' has been renamed to `services.xserver.displayManager.autoLogin.enable'.
/nix/store/z6g8jq4s1ia7pxl5mpmr6d90vbyh19c9-vm-test-run-enlightenment
/nix/store/k1ssn9yys91xs1x168zj380wjva2c195-vm-test-run-plasma5
/nix/store/gg0raf7w1zj36d504ga8aj97vy2jhyda-vm-test-run-xfce
/nix/store/j9vvjiw8sfl477pdndn8y1dca03d0267-vm-test-run-mpd

@lukegb
Copy link
Contributor Author

lukegb commented Dec 2, 2020

Running this on my system:

[lukegb@porcorosso:~]$ pulseaudio --version
pulseaudio 14.0-rebootstrapped

Audio still seems to work, so that's a +

@ryantm
Copy link
Member

ryantm commented Dec 3, 2020

closes #105774

@gebner gebner merged commit a474f0d into NixOS:staging Dec 7, 2020
@lukegb lukegb deleted the nixpkgs-pa14 branch December 10, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants