Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave-Browser: version updated from 1.16.76 to 1.17.73 #105303

Merged
merged 1 commit into from Nov 29, 2020

Conversation

@nasirhm
Copy link
Contributor

@nasirhm nasirhm commented Nov 29, 2020

Version updated for Brave Browser to 1.17.73:

  • Added a dependency for libxkbcommon.
  • Updated SHA256 for the version bumped brave browser.

Signed-off-by: nasirhm nasirhussainm14@gmail.com

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Version updated for Brave Browser from 1.16.76 to 1.17.73:

- Added a dependency for libxkbcommon.
- Updated SHA256 for the version bumped brave browser.

Signed-off-by: nasirhm <nasirhussainm14@gmail.com>
@nasirhm nasirhm force-pushed the version_bump_brave_1.17.73 branch from 177e1a4 to 1f6d64d Nov 29, 2020
@nasirhm nasirhm changed the title Brave Browser version updated to 1.17.73 Brave-Browser: version updated from 1.16.76 to 1.17.73 Nov 29, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105303 run on x86_64-linux 1

1 package built:
  • brave

@SuperSandro2000 SuperSandro2000 merged commit ba9a658 into NixOS:master Nov 29, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants