Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.hjson: init at 3.0.2 #105309

Merged
merged 1 commit into from Nov 29, 2020
Merged

python3Packages.hjson: init at 3.0.2 #105309

merged 1 commit into from Nov 29, 2020

Conversation

@bhipple
Copy link
Contributor

@bhipple bhipple commented Nov 29, 2020

This library provides a human readable extension to JSON and is used as a
dependency in packages like qmk

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bhipple bhipple requested review from FRidh and jonringer as code owners Nov 29, 2020
This library provides a human readable extension to JSON and is used as a
dependency in packages like [qmk](https://github.com/qmk/qmk_cli)

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105309 run on x86_64-linux 1

3 packages built:
  • python27Packages.hjson
  • python37Packages.hjson
  • python38Packages.hjson

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105309 run on x86_64-darwin 1

3 packages built:
  • python27Packages.hjson
  • python37Packages.hjson
  • python38Packages.hjson

Copy link
Contributor

@lukegb lukegb left a comment

The outputs into bin/ need patching, in particular:

  • Delete hjson.cmd, since that's for Windows
  • You'll probably need to patchShebangs and maybe makeWrapper hjson, but it should run without a python on the PATH

@SuperSandro2000 SuperSandro2000 merged commit 32c7524 into NixOS:master Nov 29, 2020
17 checks passed
17 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f2a2694"; rev="f2a2694cad2429c2d62b7bdd4c65432135374fbf"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f2a2694"; rev="f2a2694cad2429c2d62b7bdd4c65432135374fbf"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f2a2694"; rev="f2a2694cad2429c2d62b7bdd4c65432135374fbf"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f2a2694"; rev="f2a2694cad2429c2d62b7bdd4c65432135374fbf"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f2a2694"; rev="f2a2694cad2429c2d62b7bdd4c65432135374fbf"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f2a2694"; rev="f2a2694cad2429c2d62b7bdd4c65432135374fbf"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f2a2694"; rev="f2a2694cad2429c2d62b7bdd4c65432135374fbf"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

@lukegb sorry I was faster than you.

@bhipple can you please address this in a timely fashion and ping me in the PR?

@bhipple bhipple mentioned this pull request Nov 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants