Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: allow building for musl targets #105314

Merged
merged 1 commit into from Nov 29, 2020

Conversation

@lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Nov 29, 2020

Motivation for this change

Makes pkgsCross.<platform>.pkgsStatic.buildPackages.rustc work.

It might be worthwhile to add similar things for hostPlatform or even buildPlatform, but this would require a lot more building to test so I haven't tried it yet.

I have tested this with a modified version of @joprice's rust-nix-test. @joprice I know this doesn't solve your problem, but it is a step in the general direction.

cc @Ericson2314

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lopsided98
Copy link
Contributor Author

@lopsided98 lopsided98 commented Nov 29, 2020

@ofborg build pkgsCross.armv7l-hf-multiplatform.pkgsStatic.buildPackages.rustc

@Ericson2314 Ericson2314 merged commit 5d75fe4 into NixOS:master Nov 29, 2020
18 of 20 checks passed
@lopsided98 lopsided98 deleted the rustc-musl-target branch Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants