Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.blis: 0.7.2 -> 0.7.3 #105327

Merged
merged 2 commits into from Nov 30, 2020
Merged

Conversation

@danieldk
Copy link
Member

@danieldk danieldk commented Nov 29, 2020

Motivation for this change

Upgrades to BLIS 0.7.0:

https://github.com/explosion/cython-blis/releases/tag/v0.7.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@danieldk danieldk requested review from FRidh and jonringer as code owners Nov 29, 2020
@danieldk danieldk force-pushed the python-blis-0.7.3 branch from 61a68b1 to 1656162 Nov 29, 2020
@danieldk
Copy link
Member Author

@danieldk danieldk commented Nov 29, 2020

@ofborg build python37Packages.spacy python38Packages.spacy

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 29, 2020

aarch failure i in dependent package

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 29, 2020

I don't think openblas likes my 128 cores

  Setting up data for gemm. 1000 iters,  nO=384 nI=384 batch_size=2000
  Blis gemm...
  Total: 11032014.6484375
  5.18 seconds
  Numpy (lapack) gemm...
  BLAS : Program is Terminated. Because you tried to allocate too many memory regions.
  BLAS : Program is Terminated. Because you tried to allocate too many memory regions.
  /nix/store/xpc8bwik5ksb21if0viwmvz13rns3kld-setuptools-check-hook/nix-support/setup-hook: line 4:  9565 Segmentation fault      (core dumped) /nix/store/5aq2ix4vmk8bxs20ddqi48vc4bnk8zr5-python3-3.8.6/bin/python3.8 nix_run_setup test
cannot build derivation '/nix/store/mvyffba0hc5cdcj11ixq7zc69mcpql66-python3.8-thinc-7.4.3.drv':

@danieldk
Copy link
Member Author

@danieldk danieldk commented Nov 29, 2020

aarch failure i in dependent package

It currently does not make sense to build BLIS on anything else than x86_64. I'll update platforms.

@danieldk
Copy link
Member Author

@danieldk danieldk commented Nov 29, 2020

aarch failure i in dependent package

It currently does not make sense to build BLIS on anything else than x86_64. I'll update platforms.

Restricted platforms in the second commit.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105327 run on x86_64-linux 1

9 packages built:
  • python27Packages.blis
  • python37Packages.blis
  • python37Packages.spacy
  • python37Packages.textacy
  • python37Packages.thinc
  • python38Packages.blis
  • python38Packages.spacy
  • python38Packages.textacy
  • python38Packages.thinc

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 30, 2020

Result of nixpkgs-review pr 105327 run on x86_64-darwin 1

9 packages built:
  • python27Packages.blis
  • python37Packages.blis
  • python37Packages.spacy
  • python37Packages.textacy
  • python37Packages.thinc
  • python38Packages.blis
  • python38Packages.spacy
  • python38Packages.textacy
  • python38Packages.thinc

@SuperSandro2000 SuperSandro2000 merged commit dd33fd3 into NixOS:master Nov 30, 2020
17 checks passed
@danieldk danieldk deleted the python-blis-0.7.3 branch Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants