Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mautrix: 0.5.8 -> 0.8.3, mautrix-telegram: 0.8.2 -> 0.9.0, python3Packages.telethon: 1.14.0 -> 1.17.5 #105336

Merged
merged 3 commits into from Nov 29, 2020

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Motivation for this change

Closes #103319, Closes #92893

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105336 run on x86_64-linux 1

5 packages built:
  • mautrix-telegram
  • python37Packages.mautrix
  • python37Packages.telethon
  • python38Packages.mautrix
  • python38Packages.telethon

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105336 run on x86_64-darwin 1

4 packages built:
  • python37Packages.mautrix
  • python37Packages.telethon
  • python38Packages.mautrix
  • python38Packages.telethon

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 105336 1

5 packages built:
  • mautrix-telegram
  • python37Packages.mautrix
  • python37Packages.telethon
  • python38Packages.mautrix
  • python38Packages.telethon

@jonringer jonringer merged commit cb22277 into NixOS:master Nov 29, 2020
19 checks passed
@SuperSandro2000 SuperSandro2000 deleted the python-mautrix branch Nov 29, 2020
@Limvot
Copy link

@Limvot Limvot commented Nov 29, 2020

I think this update makes the service not work for me, as it doesn't install anything in the bin folder:
/nix/store/6gnd9dl9pbh1fnlx6zgd5n22xx54kzr3-python3.8-mautrix-telegram-0.9.0/bin/mautrix-telegram: No such file or directory

I'm guessing this is due to mautrix/telegram@a565853
but I'm not sure.

@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 29, 2020

Was this actually tested before merging?

Will take a look.

@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 29, 2020

@Limvot fixed in 878e80c, 752b6a9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants