Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xygrib: Fix build on darwin #105338

Merged
merged 1 commit into from Dec 4, 2020
Merged

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Motivation for this change

#105317 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 29, 2020
10 tasks
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105338 run on x86_64-linux 1

veprbl
veprbl approved these changes Nov 29, 2020
Copy link
Member

@veprbl veprbl left a comment

Runs, but icons are not displayed. You might want to add qtsvg to QT_PLUGIN_PATH.

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105338 run on x86_64-darwin 1

1 package built:
  • xygrib

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Runs, but icons are not displayed. You might want to add qtsvg to QT_PLUGIN_PATH.

The icons is already there but the cmake file is not installing it. Working on a fix.

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105338 run on x86_64-darwin 1

1 package built:
  • xygrib

@SuperSandro2000 SuperSandro2000 merged commit 8caeede into NixOS:master Dec 4, 2020
19 checks passed
rb2k pushed a commit to rb2k/nixpkgs that referenced this issue Dec 5, 2020
@SuperSandro2000 SuperSandro2000 deleted the xygrib-darwin branch Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants