Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: 2020.11.26 -> 2020.11.29 #105341

Merged
merged 1 commit into from Nov 29, 2020
Merged

youtube-dl: 2020.11.26 -> 2020.11.29 #105341

merged 1 commit into from Nov 29, 2020

Conversation

@Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Nov 29, 2020

Motivation for this change

https://github.com/ytdl-org/youtube-dl/releases/tag/2020.11.29

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
lukegb
lukegb approved these changes Nov 29, 2020
Copy link
Contributor

@lukegb lukegb left a comment

WFM.

@RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Nov 29, 2020

Result of nixpkgs-review pr 105341 run on x86_64-linux 1

1 package failed to build:
  • bomi
34 packages built:
  • catt
  • celluloid
  • curseradio
  • haskellPackages.cut-the-crap
  • jellyfin-mpv-shim
  • jftui
  • kodi-cli
  • lollypop
  • minitube
  • mkchromecast
  • mopidy-youtube
  • mpc-qt
  • mps-youtube
  • mpv
  • persepolis
  • plex-media-player
  • plex-mpv-shim
  • python27Packages.pafy
  • python27Packages.youtube-dl
  • python27Packages.youtube-dl-light
  • python37Packages.mpv
  • python37Packages.pafy
  • python37Packages.youtube-dl
  • python37Packages.youtube-dl-light
  • python38Packages.mpv
  • python38Packages.pafy
  • youtube-dl (python38Packages.youtube-dl)
  • youtube-dl-light (python38Packages.youtube-dl-light)
  • qimgv
  • somafm-cli
  • sublime-music
  • tartube
  • tuijam
  • ytcc

@RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Nov 29, 2020

bomi is broken on master as well

Ma27
Ma27 approved these changes Nov 29, 2020
@Ma27 Ma27 merged commit 8688a4b into NixOS:master Nov 29, 2020
19 checks passed
@Luflosi Luflosi deleted the update/youtube-dl branch Nov 29, 2020
@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 29, 2020

Thanks! Ported to stable as ae47c79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants