Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird, firefox, firefox-esr: set big-parallel #105345

Merged
merged 1 commit into from Nov 29, 2020
Merged

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 29, 2020

Firefox and Thunder time out nearly everytime. Hopefully giving them
more resources will prevent this from happening.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@FRidh FRidh requested review from lovesegfault, vcunat and andir Nov 29, 2020
@vcunat
Copy link
Member

@vcunat vcunat commented Nov 29, 2020

🤔 yes, we might try that. Though it probably makes most sense to keep this the same also in firefoxPackages.

People wanting to build themselves may notice this, as they'd have to explicitly set the feature on (some of) their machines. I don't see that as a significant down-side, as these builds really are expensive.

Copy link
Member

@lovesegfault lovesegfault left a comment

I think this makes sense, I agree perhaps it should be set for firefox too. cc. @andir

@vcunat
Copy link
Member

@vcunat vcunat commented Nov 29, 2020

Cross-ref: #103071 #103070

@FRidh
Copy link
Member Author

@FRidh FRidh commented Nov 29, 2020

People wanting to build themselves may notice this, as they'd have to explicitly set the feature on (some of) their machines. I don't see that as a significant down-side, as these builds really are expensive.

I think big-parallel is set by default nowadays.

@andir
Copy link
Member

@andir andir commented Nov 29, 2020

I think this makes sense, I agree perhaps it should be set for firefox too. cc. @andir

Go ahead and open a PR. I wanted to try that for a while now.

@FRidh FRidh changed the title thunderbird: set big-parallel thunderbird, firefox, firefox-esr: set big-parallel Nov 29, 2020
@FRidh
Copy link
Member Author

@FRidh FRidh commented Nov 29, 2020

I added firefox(-esr) to the same commit.

Firefox and Thunder time out nearly everytime. Hopefully giving them
more resources will prevent this from happening.
andir
andir approved these changes Nov 29, 2020
@ofborg ofborg bot requested review from lovesegfault, edolstra, nbp and andir Nov 29, 2020
@FRidh FRidh merged commit 29f1edf into NixOS:master Nov 29, 2020
17 of 20 checks passed
@FRidh FRidh deleted the thunderbird branch Nov 29, 2020
@vcunat
Copy link
Member

@vcunat vcunat commented Dec 6, 2020

Do you know if it seems to have helped?

@FRidh
Copy link
Member Author

@FRidh FRidh commented Dec 6, 2020

I don't dare to say, we haven't had any mass rebuilds yet.

@andir
Copy link
Member

@andir andir commented Dec 6, 2020

vcunat added a commit that referenced this issue Dec 9, 2020
Firefox and Thunder time out nearly everytime. Hopefully giving them
more resources will prevent this from happening.

(cherry picked from commit 29f1edf / PR #105345)
Too many time-outs on 20.09, so let's try this also here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants