Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nginx: add streamConfig option #105347

Merged
merged 1 commit into from Jan 7, 2021
Merged

nixos/nginx: add streamConfig option #105347

merged 1 commit into from Jan 7, 2021

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 29, 2020

Motivation for this change

having this option allows to have different stream blocks in different modules being merged properly

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Mic92
Copy link
Member Author

@Mic92 Mic92 commented Jan 2, 2021

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 2, 2021
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Jan 2, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

kisik21
kisik21 approved these changes Jan 4, 2021
Copy link
Contributor

@kisik21 kisik21 left a comment

TIL Nginx can be used as a general-purpose load balancer for any TCP or UDP connections.

The code LGTM. It's trivial enough, won't introduce any incompatibilities and expands usefulness of NixOS.

/status needs_merger

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Jan 7, 2021

Reminder: Please review!

Reminder: This Pull Request is awaiting merger. If you are the assigned reviewer with commit permission, please have a look. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.


Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

@kevincox kevincox merged commit 8455fa3 into NixOS:master Jan 7, 2021
17 checks passed
@Mic92 Mic92 deleted the nginx branch Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants