Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cheat: 4.1.1 -> 4.2.0 #105349

merged 1 commit into from Nov 29, 2020

cheat: 4.1.1 -> 4.2.0 #105349

merged 1 commit into from Nov 29, 2020


Copy link

@Mic92 Mic92 commented Nov 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
lukegb approved these changes Nov 29, 2020
Copy link

@lukegb lukegb left a comment

Builds (and runs) for me on x86_64-linux and x86_64-darwin.

@Mic92 Mic92 merged commit a41808f into NixOS:master Nov 29, 2020
19 of 20 checks passed
@Mic92 Mic92 deleted the cheat branch Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants