Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rivet: 3.1.2 -> 3.1.3 #105363

Merged
merged 2 commits into from Dec 11, 2020
Merged

rivet: 3.1.2 -> 3.1.3 #105363

merged 2 commits into from Dec 11, 2020

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Nov 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@veprbl
Copy link
Member Author

@veprbl veprbl commented Nov 29, 2020

@GrahamcOfBorg build rivet

@veprbl veprbl marked this pull request as ready for review Nov 29, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 30, 2020

Result of nixpkgs-review pr 105363 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python27Packages.yoda
9 packages built:
  • fastnlo
  • herwig
  • python37Packages.rivet
  • python37Packages.yoda
  • rivet (python38Packages.rivet)
  • yoda (python38Packages.yoda)
  • sherpa
  • thepeg
  • yoda-with-root

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 30, 2020

Result of nixpkgs-review pr 105363 1

1 package marked as broken and skipped:
  • python27Packages.yoda
2 packages failed to build:
  • sherpa
  • yoda-with-root
7 packages built:
  • fastnlo
  • herwig
  • python37Packages.rivet
  • python37Packages.yoda
  • rivet (python38Packages.rivet)
  • yoda (python38Packages.yoda)
  • thepeg

sherpa

  CXX      libToolsOrg_la-Getter_Function.lo                                                                                                                                      [40/45777]  CXX      libToolsOrg_la-My_MPI.lo                                                                                                                                                           CXX      libToolsOrg_la-Exception.lo                                                                                                                                                        CXX      libToolsOrg_la-Exception_Handler.lo                                                                                                                                                CXX      libToolsOrg_la-My_File.lo                                                                                                                                                          CXX      libToolsOrg_la-File_IO_Base.lo                                                                                                                                                     CXX      libToolsOrg_la-Read_Write_Base.lo                                                                                                                                                  CXX      libToolsOrg_la-Run_Parameter.lo                                                                                                                                                  Run_Parameter.C:37:15: error: use of undeclared identifier 'CTL_HW'                                                                                                                           int mib[2]={CTL_HW,HW_PHYSMEM};                                                                                                                                                                         ^                                                                                                                                                                             Run_Parameter.C:37:22: error: use of undeclared identifier 'HW_PHYSMEM'                                                                                                                       int mib[2]={CTL_HW,HW_PHYSMEM};                                                                                                                                                                                ^                                                                                                                                                                      Run_Parameter.C:40:7: error: use of undeclared identifier 'sysctl'                                                                                                                            if (sysctl(mib,miblen,&pmem,&len,NULL,0)!=0) {                                                                                                                                                  ^                                                                                                                                                                                     Run_Parameter.C:56:15: error: use of undeclared identifier 'CTL_HW'                                                                                                                           int mib[2]={CTL_HW,HW_AVAILCPU};                                                                                                                                                                        ^
Run_Parameter.C:56:22: error: use of undeclared identifier 'HW_AVAILCPU'
  int mib[2]={CTL_HW,HW_AVAILCPU};
                     ^
Run_Parameter.C:59:7: error: use of undeclared identifier 'sysctl'
  if (sysctl(mib,miblen,&ncpu,&len,NULL,0)!=0) {
      ^
Run_Parameter.C:60:12: error: use of undeclared identifier 'HW_NCPU'
    mib[1]=HW_NCPU;
           ^
Run_Parameter.C:61:9: error: use of undeclared identifier 'sysctl'
    if (sysctl(mib,miblen,&ncpu,&len,NULL,0)!=0) {
        ^
8 errors generated.
make[4]: *** [Makefile:854: libToolsOrg_la-Run_Parameter.lo] Error 1
make[4]: Leaving directory '/private/tmp/nix-build-sherpa-2.2.10.drv-0/SHERPA-MC-2.2.10/ATOOLS/Org'
make[3]: *** [Makefile:594: all] Error 2
make[3]: Leaving directory '/private/tmp/nix-build-sherpa-2.2.10.drv-0/SHERPA-MC-2.2.10/ATOOLS/Org'
make[2]: *** [Makefile:493: all-recursive] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-sherpa-2.2.10.drv-0/SHERPA-MC-2.2.10/ATOOLS'
make[1]: *** [Makefile:572: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-sherpa-2.2.10.drv-0/SHERPA-MC-2.2.10'
make: *** [Makefile:498: all] Error 2

@veprbl
Copy link
Member Author

@veprbl veprbl commented Dec 1, 2020

Failing build for sherpa is failing on x86_64-darwin with current master: https://hydra.nixos.org/job/nixpkgs/trunk/sherpa.x86_64-darwin/all

@SuperSandro2000 SuperSandro2000 merged commit cdbbe25 into NixOS:master Dec 11, 2020
21 of 23 checks passed
@veprbl veprbl deleted the pr/rivet_3_1_3 branch Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants