Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery-dl: 1.15.2 -> 1.15.4 #105367

Merged
merged 1 commit into from Nov 29, 2020
Merged

gallery-dl: 1.15.2 -> 1.15.4 #105367

merged 1 commit into from Nov 29, 2020

Conversation

@siraben
Copy link
Member

@siraben siraben commented Nov 29, 2020

Motivation for this change

Update gallery-dl and fix expression.

See the section on Python dependency handling for the rationale.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@siraben
Copy link
Member Author

@siraben siraben commented Nov 29, 2020

Result of nixpkgs-review pr 105367 1

1 package built:
  • gallery-dl

@RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Nov 29, 2020

Result of nixpkgs-review pr 105367 run on x86_64-linux 1

1 package built:
  • gallery-dl

@Ma27 Ma27 merged commit a7573a0 into NixOS:master Nov 29, 2020
19 checks passed
@siraben siraben deleted the gallery-dl-update branch Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants