Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.odate: init at 0.6 #105373

merged 1 commit into from Dec 6, 2020

ocamlPackages.odate: init at 0.6 #105373

merged 1 commit into from Dec 6, 2020


Copy link

@vbgl vbgl commented Nov 29, 2020

Motivation for this change

Simple date and duration manipulation in OCaml:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@rissson rissson commented Nov 29, 2020

Result of nixpkgs-review pr 105373 1

1 package built:
  • ocamlPackages.odate

Copy link

@sternenseemann sternenseemann left a comment

What about tests (test/

Copy link
Contributor Author

@vbgl vbgl commented Dec 2, 2020

Tests are broken: hhugo/odate#7

@vbgl vbgl merged commit cf7475d into NixOS:master Dec 6, 2020
16 checks passed
@vbgl vbgl deleted the ocaml-odate-0.6 branch Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants