Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: treewide: splice more nested package sets #105374

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Nov 29, 2020

Motivation for this change

So far this just has some functions that might come in handy. Next step
is to find package sets that provide things used as non-buildInputs
(most of them seem to not fit that?).

I've always hated this splicing monster. Maybe others can tell me where
this might be worth it.

CC @FRidh @globin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
So far this just has some functions that might come in handy. Next step
is to find package sets that provide things used as non-buildInputs
(most of them seem to not fit that?).

I've always hated this splicing monster. Maybe others can tell me where
this might be worth it.

CC @FRidh @globin
@@ -131,6 +131,17 @@ in

newScope = extra: lib.callPackageWith (splicedPackagesWithXorg // extra);

makeScopeWithSplicing = lib.makeScopeWithSplicing splicePackages pkgs.newScope;

topProjectedSpliced = attr: {
Copy link
Member

@FRidh FRidh Dec 19, 2020

Perhaps split attr on dots to allow for nested sets?

@FRidh
Copy link
Member

@FRidh FRidh commented Mar 8, 2021

I wonder how to access the buildPackages variant of pythonPackages, see b1d8335

@stale
Copy link

@stale stale bot commented Sep 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale label Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants