Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucx: 1.8.1 -> 1.9.0 #105377

Merged
merged 1 commit into from Nov 29, 2020
Merged

ucx: 1.8.1 -> 1.9.0 #105377

merged 1 commit into from Nov 29, 2020

Conversation

@markuskowa
Copy link
Member

@markuskowa markuskowa commented Nov 29, 2020

Motivation for this change

Regular upgrade:
https://github.com/openucx/ucx/blob/master/NEWS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@markuskowa
Copy link
Member Author

@markuskowa markuskowa commented Nov 29, 2020

@GrahamcOfBorg test slurm

@markuskowa markuskowa merged commit 4971583 into NixOS:master Nov 29, 2020
21 of 22 checks passed
@markuskowa markuskowa deleted the upd-ucx branch Nov 29, 2020
@RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Nov 29, 2020

Result of nixpkgs-review pr 105377 run on x86_64-linux 1

19 packages marked as broken and skipped:
  • python27Packages.fipy
  • python37Packages.arviz
  • python37Packages.baselines
  • python37Packages.cntk
  • python37Packages.dm-sonnet
  • python37Packages.edward
  • python37Packages.graph_nets
  • python37Packages.optuna
  • python37Packages.pymc3
  • python37Packages.rl-coach
  • python37Packages.tensorflow
  • python37Packages.tensorflow-build
  • python37Packages.tensorflow-build_1
  • python37Packages.tensorflow-probability
  • python37Packages.tensorflowWithCuda
  • python37Packages.tensorflowWithoutCuda
  • python37Packages.tensorflow_1
  • python37Packages.tflearn
  • python38Packages.cntk
5 packages failed to build:
  • cntk
  • openmolcas
  • python27Packages.cntk
  • python37Packages.datashader
  • python38Packages.datashader
63 packages built:
  • dl-poly-classic-mpi
  • elmerfem
  • freecad
  • getdp
  • globalarrays
  • gromacsDoubleMpi
  • gromacsMpi
  • haskellPackages.haskell-mpi
  • hdf5-mpi
  • highfive-mpi
  • hpcg
  • hpl
  • ior
  • lammps-mpi
  • migrate
  • netcdf-mpi
  • neuron-full (python27Packages.neuron-mpi)
  • neuron-mpi
  • openmpi
  • paraview
  • parmetis
  • precice
  • python27Packages.mpi4py
  • python37Packages.dask-gateway
  • python37Packages.dask-jobqueue
  • python37Packages.dask-ml
  • python37Packages.dask-mpi
  • python37Packages.dask-xgboost
  • python37Packages.dftfit
  • python37Packages.distributed
  • python37Packages.fenics
  • python37Packages.fipy
  • python37Packages.h5py-mpi
  • python37Packages.lammps-cython
  • python37Packages.mask-rcnn
  • python37Packages.mpi4py
  • python37Packages.neuron-mpi
  • python37Packages.streamz
  • python37Packages.stumpy
  • python37Packages.tensorflow_2 (python37Packages.tensorflow-build_2)
  • python38Packages.dask-gateway
  • python38Packages.dask-jobqueue
  • python38Packages.dask-ml
  • python38Packages.dask-mpi
  • python38Packages.dask-xgboost
  • python38Packages.dftfit
  • python38Packages.distributed
  • python38Packages.fenics
  • python38Packages.fipy
  • python38Packages.h5py-mpi
  • python38Packages.lammps-cython
  • python38Packages.mask-rcnn
  • python38Packages.mpi4py
  • python38Packages.neuron-mpi
  • python38Packages.streamz
  • python38Packages.stumpy
  • python38Packages.tensorflow_2 (python38Packages.tensorflow-build_2)
  • quantum-espresso-mpi
  • raxml-mpi
  • scalapack
  • scotch
  • siesta-mpi
  • ucx

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 30, 2020

  • cntk

Already broken on master:

Invalid openblas directory /nix/store/fl9d5425p24capww1f0z6h4mkxdxj8p1-openblas-0.3.12
builder for '/nix/store/jwrq3c1vw3cip8ns2qvdsb99lnywd8br-CNTK-2.7.drv' failed with exit code 1
error: build of '/nix/store/jwrq3c1vw3cip8ns2qvdsb99lnywd8br-CNTK-2.7.drv' failed
  • openmolcas

source hash mismatch on master

  • python27Packages.cntk

  • python37Packages.datashader

  • python38Packages.datashader

Tests fail on master.

Still please do not self merge without nixpkgs-review to make sure you are not introducing regressions.

@markuskowa
Copy link
Member Author

@markuskowa markuskowa commented Nov 30, 2020

Thanks for double checking but I think in this particular case nixpkgs-review is not necessary. It is only a plugin of openmpi that depends on UCX. I think it sufficient here to check that openmpi works properly. Even though an update of UCX generates a lot of rebuilds it is unlikely that any other package is impacted.
It is good to know though that openmolcas ran into yet another hash mismatch problem. I will take look at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants