Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qjackctl: add jackSession option #105382

Merged
merged 1 commit into from Dec 24, 2020
Merged

qjackctl: add jackSession option #105382

merged 1 commit into from Dec 24, 2020

Conversation

@suhr
Copy link
Contributor

@suhr suhr commented Nov 29, 2020

Motivation for this change

This adds jackSession option, which allows to enable or disable jack session support.

The option is disabled by default for the following reasons:

  1. The JACK-Session API is deprecated: https://jackaudio.org/api/group__JackSessionManagerAPI.html
  2. Disabling this feature allows to use qjackctl with PipeWire

See also: #102547

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cillianderoiste

@ashkitten
Copy link
Contributor

@ashkitten ashkitten commented Dec 1, 2020

works for me with pipewire

@collares
Copy link
Member

@collares collares commented Dec 15, 2020

I hit this problem today.Thanks for the patch! Would be great to get this merged :)

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Dec 23, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/303

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 23, 2020

Result of nixpkgs-review pr 105382 run on x86_64-linux 1

1 package built:
  • qjackctl

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Please squash the review commit.

@suhr suhr force-pushed the qjackctl-session branch from 78caffc to 43244d4 Dec 23, 2020
@suhr suhr force-pushed the qjackctl-session branch from 43244d4 to c25347d Dec 23, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 23, 2020

Result of nixpkgs-review pr 105382 run on x86_64-linux 1

1 package built:
  • qjackctl

@gebner gebner merged commit e3b15e2 into NixOS:master Dec 24, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants