Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2Packages.ecpy: unbreak due to invalid code #105387

Merged
merged 1 commit into from Nov 30, 2020

Conversation

@freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 29, 2020

Motivation for this change

setup.py contains a broken code related to a "reqs" variable to add an optional dependency. This patch remove it.

I also added an import check as no other tests are active

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@freezeboy freezeboy requested review from FRidh and jonringer as code owners Nov 29, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 29, 2020

do you mind upstreaming this change?

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

@freezeboy
Copy link
Contributor Author

@freezeboy freezeboy commented Nov 29, 2020

I a not sure how to cleanly patch this problem, here I remove the line because nix provides the future dependency, but I don't know how it should be done with other setups

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 30, 2020

Result of nixpkgs-review pr 105387 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • python27Packages.ledgerblue
7 packages built:
  • ledger_agent (python38Packages.ledger_agent)
  • python27Packages.ecpy
  • python37Packages.ecpy
  • python37Packages.ledger_agent
  • python37Packages.ledgerblue
  • python38Packages.ecpy
  • python38Packages.ledgerblue

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 30, 2020

Result of nixpkgs-review pr 105387 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python27Packages.ledgerblue
7 packages built:
  • ledger_agent (python38Packages.ledger_agent)
  • python27Packages.ecpy
  • python37Packages.ecpy
  • python37Packages.ledger_agent
  • python37Packages.ledgerblue
  • python38Packages.ecpy
  • python38Packages.ledgerblue

@SuperSandro2000 SuperSandro2000 merged commit ea35612 into NixOS:master Nov 30, 2020
17 checks passed
@freezeboy freezeboy deleted the unbreak-py2-ecpy branch Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants